Bug Fix: Only override forceSvg from localStorage when the key is present#5834
Merged
rileyajones merged 1 commit intotensorflow:masterfrom Aug 2, 2022
Merged
Conversation
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
…sent (tensorflow#5834) only override forceSVG from localStorage when the key is present
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
…sent (tensorflow#5834) only override forceSVG from localStorage when the key is present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
We always override the value of
forceSvgregardless of whether a value is set in localStorage. This is an existing bug that is only coming to light now that we persist feature flags to the queryParams.Stop removing experiment related query parameters #5717
Detailed steps to verify changes work correctly (as executed by you)
forceSVGquery parameter is not set.